add ability to import multisig wallet to Coldcard via USB #7682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgbckbone
commented
Feb 25, 2022
| @@ -1,19 +1,15 @@ | |||
| import time, os | |||
There was a problem hiding this comment.
removed unused imports
scgbckbone
commented
Feb 25, 2022
| btn_export = QPushButton(_("Export multisig for Coldcard as file")) | ||
| btn_export.clicked.connect(lambda unused: self.export_multisig_setup(main_window, wallet)) | ||
| buttons.append(btn_export) | ||
| btn_import_usb = QPushButton(_("Import multisig to Coldcard via USB")) |
There was a problem hiding this comment.
Button texts are kind of long - but imo more comprehensible
|
what do you think @SomberNight ? I'd say it is ready... |
…coldcard_import_multisig_walet_via_usb
|
merged current master in and tested import via USB. This is very helpful for devs that do not want to handle sd cards all the time - would be nice if it can go in @SomberNight @doc-hex |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not sure how to add new messages to translations - so I have not added them.