Add and Example Script #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the page number (where available) and the contents of any notes recorded with that highlight. highlight.page will return "Page: 7" or "Location: 123" depending on whether the page number is available...
Updated test data to include highlight.page and highlight.note
Update fetching_books_and_highlights_test.rb
Fixed test files to include notes and page data
Updated to include details of highlight.page and highlight.note
Added description of script to start
|
Should say this is reliant on changes in my other PR. |
|
I left some feedback on #19, some of which I now realize I should have left here. Either way, my general comments remain the same. Thanks for these PRs. 👊 |
|
Resolved in other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an example script which uses the framework to create a separate .txt file for each book in markdown format which includes all quotes, page numbers, notes and generates a kindle:// link to the highlight.
I use this to save to my dropbox folder and then display in Uylsses as a writing prompt.