Fix Find Errors #641
Open
Fix Find Errors #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 72.15% 73.05% +0.89%
==========================================
Files 174 175 +1
Lines 11937 12342 +405
==========================================
+ Hits 8613 9016 +403
- Misses 3110 3111 +1
- Partials 214 215 +1 ☔ View full report in Codecov by Sentry. |
hulto
requested changes
Feb 21, 2024
| } | ||
| } | ||
| Ok(out) | ||
| } | ||
|
|
||
| pub fn find( | ||
| pub fn find<'v>( |
There was a problem hiding this comment.
Please add a negative test to make sure erroring works
hulto
reviewed
Apr 17, 2024
| @@ -35,7 +37,7 @@ fn check_path( | |||
| let metadata = path.metadata()?.permissions(); | |||
| #[cfg(unix)] | |||
| { | |||
| if metadata.mode() != (permissions as u32) { | |||
| if metadata.mode() & 0o777 != (permissions as u32) { | |||
There was a problem hiding this comment.
Will this only match on 777 perms?
There was a problem hiding this comment.
Binary AND, removes the early bits so we only care about rwx. I can add back the 4th bit for SUID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix Bug
Which issue(s) this PR fixes:
Fixes #428