main: return Verify error; add dependency injection wrapper for testability #1059
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix returning nil on Verify failure in the registry path. Add a small testable wrapper (registryCommandWith) that accepts a store factory, allowing tests to inject a fake containerd-backed store and assert that Verify errors are propagated. Add a unit test using the wrapper and a fake store to ensure the registry command returns an error when Verify fails.
artem-tkachuk
force-pushed
the
containerd-verify-return-err
branch
from
bd13a1f to
d33e32d
Compare
artem-tkachuk
changed the title
artem-tkachuk
commented
Oct 27, 2025
| err = ociStore.Verify(ctx, args.ContainerdRegistryConfigPath) | ||
| if err != nil { | ||
| return nil | ||
| return err |
There was a problem hiding this comment.
This is the actual change in this PR – everything else is testing infra and a test to show the failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify()failures instead of returningnilin the registry pathAdd
registryCommandWith(ctx, args, newStore)to inject a store factory for tests – current and future :)Verify()errors are returned