-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Buckeye Preparation #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Salah,
Thanks for this PR.
I left some early comments about this PR, they are mostly related to docstring. I will take a closer look next week. :)
Example | ||
------- | ||
>>> buckeye_dir = 'datasets/Buckeye' | ||
>>> save_folder = 'buckeye_preparation/' | ||
>>> prepare_buckeye(buckeye_dir, save_folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this example since it won't work with the CI/CD
prepare_csv(buckeye_dir, save_folder, "test.csv", TEST_PREFIXES) | ||
|
||
|
||
def treat_word_file(wrd, buckeye_dir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add a docstring about this function / input args etc?
return csvs | ||
|
||
|
||
def unzip_buckeye(buckeye_dir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstring please :p
) | ||
|
||
|
||
def prepare_csv(buckeye_dir, save_folder, csv_file, prefixes): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstring please :p
Thank you @salah-zaiem and @Adel-Moumen |
…n#19) This reverts commit bd3e1fcf9b2f046ff00ebcb2f54738f96aadee54.
Added the preparation and its launch in the training script