Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Buckeye Preparation #19

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Added Buckeye Preparation #19

merged 3 commits into from
Feb 14, 2024

Conversation

salah-zaiem
Copy link
Collaborator

Added the preparation and its launch in the training script

@salah-zaiem
Copy link
Collaborator Author

@Adel-Moumen

Copy link
Collaborator

@Adel-Moumen Adel-Moumen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Salah,

Thanks for this PR.

I left some early comments about this PR, they are mostly related to docstring. I will take a closer look next week. :)

Comment on lines 38 to 42
Example
-------
>>> buckeye_dir = 'datasets/Buckeye'
>>> save_folder = 'buckeye_preparation/'
>>> prepare_buckeye(buckeye_dir, save_folder)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this example since it won't work with the CI/CD

prepare_csv(buckeye_dir, save_folder, "test.csv", TEST_PREFIXES)


def treat_word_file(wrd, buckeye_dir):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a docstring about this function / input args etc?

return csvs


def unzip_buckeye(buckeye_dir):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring please :p

)


def prepare_csv(buckeye_dir, save_folder, csv_file, prefixes):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring please :p

@mravanelli
Copy link
Contributor

Thank you @salah-zaiem and @Adel-Moumen

@mravanelli mravanelli merged commit 1a27682 into speechbrain:main Feb 14, 2024
1 check passed
TheRealSal pushed a commit to TheRealSal/benchmarks that referenced this pull request Nov 26, 2024
…n#19)

This reverts commit bd3e1fcf9b2f046ff00ebcb2f54738f96aadee54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants