Fix IndexOutOfRangeException in ExceptionFormatter #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b2689be introduced a regression when stacktrace don't have frame.
Here is the crash in my app.
The change that caused this issue is that stackTrace.GetFrame(0) has been replaced by stackTrace.GetFrames()[0].
Method GetFrame does index bound check whereas stackTrace.GetFrames()[0] is a simple array access and don't.
I put back the previous method to fix the issue.
I tried to make a test to cover this case but I failed to create an exception with no frame.