Changed IConfigurator to return IConfigurator instead of void #1762
+25
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1219
Changes
Changed IConfigurator to return IConfigurator instead of void for the following interface methods:
SetHelpProvider
SetHelpProvider<T>
AddExample
However, other methods like AddCommand narrow the configurator so the order of chaining methods does matter. Just to point that out. Chaining is optional obviously.
I saw the ICofiguratorOfT also returns void for SetDescription, and AddExample. However, it becomes a bigger challenge to change that because
Configurator<T>
implements bothIUnsafeBranchConfigurator
andIConfigurator<T>
and both share the SetDescription and AddExample but one does not take in the generic type. Probably would need "unsafe configurator of T" or something?Please upvote 👍 this pull request if you are interested in it.