ReaderWriterQueue and Update README #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcopik
approved these changes
Mar 20, 2024
|
@omcal Thank you for this contribution! One question: what do you mean by: "Note: Additional testing may be required to ensure proper integration."? Did you build rFaaS and verified that we properly have everything linked and included? |
|
Yes, I did in my local but since there is no CI/CD i was not sure about that :D so I added that note |
|
@oisildak Hi! I see you deleted the repository. Unfortunately, the PR slipped through the cracks. I will test it locally and recreate the PR from your commit. It would be best to have this commit as your authorship and contribution - in that case, please recreate the PR with this commit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14 Add ReaderWriterQueue and Update README