Fixed a Possible Bug in the Extended State Fusion #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `connections_to_make` was a class variable and not marked as a dace property and hence shared between all instances. It is now an instance variable and thus private. Also the variable was never cleared, so technically, the connections should have accumulated inside it. Furthermore, the transformation assumed that `can_be_applied()` was called immediately before `apply()`, because the `can_be_applied()` function populates the `connections_to_make`. However, this behaviour is not guaranteed and now `apply()` explicitly calls `can_be_applied()` to make sure that `connections_to_make` is properly populated.
acalotoiu
requested changes
Jul 17, 2025
|
I am not fully sure how a unit test for that thing would look like, as it essentially would be a test that there is no (observable) state, between two invocation of the same object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
connections_to_makewas a class variable and not marked as a dace property and hence shared between all instances. It is now an instance variable and thus private.Also the variable was never cleared, so technically, the connections should have accumulated inside it.
Furthermore, the transformation assumed that
can_be_applied()was called immediately beforeapply(), because thecan_be_applied()function populates theconnections_to_make. However, this behaviour is not guaranteed and nowapply()explicitly callscan_be_applied()to make sure thatconnections_to_makeis properly populated.