Allow customising where the ray.php config file can go with an env variable #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable. Setting the env variable RAY_CONFIG_DIR will look for ray.php in that directory instead of in the root project directory. This allows us to separate our config out of the main codebase.
patinthehat
suggested changes
Nov 9, 2024
| @@ -109,7 +109,8 @@ class Ray | |||
|
|
|||
| public static function create(?Client $client = null, ?string $uuid = null): self | |||
| { | |||
| $settings = SettingsFactory::createFromConfigFile(); | |||
| $configDir = (isset($_SERVER['RAY_CONFIG_DIR'])) ? $_SERVER['RAY_CONFIG_DIR'] : null; | |||
There was a problem hiding this comment.
I think using getenv() here would be a better choice instead of directly accessing $_SERVER. It might also be good to do some validation of the value before passing it to SettingsFactory.
| @@ -109,7 +109,8 @@ class Ray | |||
|
|
|||
| public static function create(?Client $client = null, ?string $uuid = null): self | |||
| { | |||
| $settings = SettingsFactory::createFromConfigFile(); | |||
| $configDir = (isset($_SERVER['RAY_CONFIG_DIR'])) ? $_SERVER['RAY_CONFIG_DIR'] : null; | |||
| $settings = SettingsFactory::createFromConfigFile($configDir); | |||
There was a problem hiding this comment.
I think we should also add some additional unit tests to ensure the functionality works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the env variable RAY_CONFIG_DIR will look for ray.php in that directory instead of in the root project directory. This allows us to separate our config out of the main codebase.
Not sure if you accept random PRs or if you've got a better way of doing this, but it would be very handy to be able to put the ray.php config file somewhere else. So I added this code to let you change where it looks for it.