Add addXmlDeclaration parameter (#216)

* Add addXmlDeclaration parameter * Add test
spatie · May 11, 2023 · e210b98 · e210b98
1 parent bd3a01a
commit e210b98
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/ArrayToXml.php b/src/ArrayToXml.php
@@ -24,7 +24,8 @@ public function __construct(
         string | null $xmlEncoding = null,
         string $xmlVersion = '1.0',
         array $domProperties = [],
-        bool | null $xmlStandalone = null
+        bool | null $xmlStandalone = null,
+        bool $addXmlDeclaration = true
     ) {
         $this->document = new DOMDocument($xmlVersion, $xmlEncoding ?? '');
 
@@ -36,6 +37,8 @@ public function __construct(
             $this->setDomProperties($domProperties);
         }
 
+        $this->addXmlDeclaration = $addXmlDeclaration;
+
         $this->replaceSpacesByUnderScoresInKeyNames = $replaceSpacesByUnderScoresInKeyNames;
 
         if (! empty($array) && $this->isArrayAllKeySequential($array)) {
@@ -61,7 +64,8 @@ public static function convert(
         string $xmlEncoding = null,
         string $xmlVersion = '1.0',
         array $domProperties = [],
-        bool $xmlStandalone = null
+        bool $xmlStandalone = null,
+        bool $addXmlDeclaration = true,
     ): string {
         $converter = new static(
             $array,
@@ -70,7 +74,8 @@ public static function convert(
             $xmlEncoding,
             $xmlVersion,
             $domProperties,
-            $xmlStandalone
+            $xmlStandalone,
+            $addXmlDeclaration
         );
 
         return $converter->toXml();

diff --git a/tests/ArrayToXmlTest.php b/tests/ArrayToXmlTest.php
@@ -110,6 +110,10 @@
     assertMatchesXmlSnapshot(ArrayToXml::convert([], '', false, null, '1.0', [], false));
 });
 
+it('accepts an xml declaration value', function () {
+    assertMatchesXmlSnapshot(ArrayToXml::convert([], '', false, null, '1.0', [], null, false));
+});
+
 it('can handle values as collection', function () {
     assertMatchesXmlSnapshot(ArrayToXml::convert([
         'user' => [

diff --git a/tests/__snapshots__/ArrayToXmlTest__it_accepts_an_xml_declaration_value__1.xml b/tests/__snapshots__/ArrayToXmlTest__it_accepts_an_xml_declaration_value__1.xml
@@ -0,0 +1 @@
+<root/>