fix: CSS queries with xpath-incompatible pseudo-classes raise an exception at query parse time #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- use parens more intentionally in the rexical macros - rename the CSS ID token macro from `name` to `charref` to match XPath CharRef - extract a `name` macro that matches XPath Name
Some pseudo-classes cannot be converted into an XPath function name,
and libxml2 will raise an Nokogiri::XML::XPath::SyntaxError at
query-time:
nokogiri/xml/searchable.rb:238:in `evaluate': ERROR: Invalid expression: //*:div[nokogiri:-moz-drag-over(.)] (Nokogiri::XML::XPath::SyntaxError)
This change moves the error from query-time to parse-time, in the
hopes that this is more rescuable (and the error is more descriptive):
nokogiri/css/parser_extras.rb:86:in `on_error': unexpected '-' after ':' (Nokogiri::CSS::SyntaxError)
Closes #3193
flavorjones
force-pushed
the
3193-ncname-pseudoclass
branch
from
e2f2905
to
d3a60cb
Compare
flavorjones
added a commit
that referenced
this pull request
Jun 11, 2024
**What problem is this PR intended to solve?** After some thought, I decided I didn't like the solution to #3193 introduced in #3197, in which the exception was raised by the CSS parser, because it's an XPath translation problem and not a CSS problem. This PR reverts that change, and instead raises the exception from the XPathVisitor class when it tries to translate the pseudo-class selector or function into an XPath function call. **Have you included adequate test coverage?** Yes. **Does this change affect the behavior of either the C or the Java implementations?** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
fix: raise CSS::SyntaxError if a pseudo-class is not an XPath Name
Some pseudo-classes cannot be converted into an XPath function name, and libxml2 will raise an Nokogiri::XML::XPath::SyntaxError at query-time:
This change moves the error from query-time to parse-time, in the hopes that this is more rescuable (and the error is more descriptive):
Closes #3193
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
N/A