Fix incorrect matching of skycoords with pixel coords in catalog results #3464
+17
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously matching the filtered list of N pixel coords in the viewer bounds with the first N skycoords, which led to mismatches between the pixel and sky coords for the results. There's a smarter fix here that involves zipping before filtering both at once rather than doing the check in the loop, this was mostly a quick hack to get the code working properly. If we're worried about performance I can figure out the better way to do this, if not we can merge this for now to fix the bug.