Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect matching of skycoords with pixel coords in catalog results #3464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Feb 25, 2025

This was previously matching the filtered list of N pixel coords in the viewer bounds with the first N skycoords, which led to mismatches between the pixel and sky coords for the results. There's a smarter fix here that involves zipping before filtering both at once rather than doing the check in the loop, this was mostly a quick hack to get the code working properly. If we're worried about performance I can figure out the better way to do this, if not we can merge this for now to fix the bug.

@rosteen rosteen added the bug Something isn't working label Feb 25, 2025
@rosteen rosteen added this to the 4.1.2 milestone Feb 25, 2025
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Feb 25, 2025
@pllim pllim added the backport-v4.1.x on-merge: backport to v4.1.x label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.55%. Comparing base (d8a70b2) to head (0eecb3b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/imviz/plugins/catalogs/catalogs.py 88.88% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (88.88%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3464   +/-   ##
=======================================
  Coverage   87.54%   87.55%           
=======================================
  Files         128      128           
  Lines       19959    19955    -4     
=======================================
- Hits        17474    17471    -3     
+ Misses       2485     2484    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor

pllim commented Feb 25, 2025

Do we need a regression test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x bug Something isn't working imviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants