Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #62

Closed
wants to merge 6 commits into from
Closed

Release 2.0.0 #62

wants to merge 6 commits into from

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Mar 28, 2016

tas50 added 6 commits March 28, 2016 11:41
We just need to stop it.  Disabling it just requires us to enable it
later.
Rename all recipes you wouldn't apply to a node with _ prefix
Rename default to local
Rearrange recipe usage in readme
Remove not_if section of the service block.  This was preventing the service from starting in server mode
Update Kitchen suites / travis config
@chewi
Copy link
Contributor

chewi commented Mar 29, 2016

Thanks for merging my stuff earlier.

My main concern here is the removal of the service not_if. On the server side, the empty client.keys issue is very annoying. I have seen confused posts on the mailing list about it so we should guard against it. I am trying to get it fixed upstream at ossec/ossec-hids/issues/662. On the agent side, agent_server_ip is determined by a search, which might come up blank if the server isn't ready yet. The Chef run would then die when trying to start the service.

If we're going to break things now then I really hope you would look at #48 and perhaps even consider dropping the existing SSH stuff as authd is very much safer. It's a shame OSSEC 2.9 isn't out yet as that adds certificate verification.

@tas50 tas50 closed this Jun 20, 2016
@tas50
Copy link
Contributor Author

tas50 commented Jun 20, 2016

Closing this out as it did more harm than good

@lock
Copy link

lock bot commented Jul 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants