Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows master support #668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

troyready
Copy link

@troyready troyready commented Dec 16, 2017

Description

Adds support for Jenkins master on Windows

Issues Resolved

#437 , #547

Check List

@troyready
Copy link
Author

troyready commented Dec 16, 2017

The basic existing tests are working for me now. Given a run_list of:

      - recipe[jenkins_server_wrapper::default]
      - recipe[jenkins_plugin::install]
      - recipe[jenkins_job::create]
      - recipe[jenkins_user::create]

all tests pass in assert_plugin_installed_spec.rb, assert_job_created_spec.rb, & assert_user_created_spec.rb.

I started working on updating additional tests, but they don't all appear to be up-to-date/working (e.g. credentials_create has jenkins_password_credentials resources without id's specified, causing validation errors unrelated to this PR).

I don't want to prematurely check off the testing tasks, but FWIW the "new" functionality of install via MSI is covered and pretty much everything else leverages the web ui or local java execution (which is already tested). Open to suggestions on next steps.

Signed-off-by: troyready <[email protected]>
@habelson
Copy link

any momentum on getting this PR pulled in?

@Stromweld
Copy link
Contributor

@troyready can you rebase this on current master and verify all checks still pass. Then we can possibly get someone to review it.

@troyready
Copy link
Author

I don't have the bandwidth to finish this now, sorry. The changes should be pretty straightforward for someone to pick up, only real functional change I think is figuring out the new conditional check for inspec (I think RUBY_PLATFORM.include?('mingw') will be wrong now given the local inspec execution)

@dnorenavega-lightbox
Copy link

Need this please merge

@xorima
Copy link
Contributor

xorima commented Nov 20, 2020

@troyready / @dnorenavega-EDR can we get this rebased so we can look to have it merged please?

@xorima xorima added the Waiting on Contributor Awaiting on the person who raised this to update label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on Contributor Awaiting on the person who raised this to update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants