-
Notifications
You must be signed in to change notification settings - Fork 0
Release for repo.sourcify.dev #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…are unverified ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here a list of unresolved issues:
-
Improve padding of sections' title (now it's 0)
-
open in remix is not working, idk if I'm doing something wrong. When I click the button, remix opens with a banner on the bottom "initiating contract-verification/lookupAndSave and calling "sourcify" ...", but then nothing happens.
-
Copy and download buttons for editors
there is no copy button
Then this is a list of other issues I found:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, while testing some changes in the files I noticed that the files are not formatted via prettier
.
What's the issue here? I can't understand. It's properly padded
Yeah another
Added everywhre except bytecodes
Good catch again. It was because we forgot the "CBORAuxdataTransformations" in creation bytecode |
Done fixes can you please double check? I think we are on the same page now @marcocastignoli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow so clean! Great job! 🎉
This release implements the changes laid out in ethereum/sourcify#1997
Some of the rationale of the decisions are made are also stated under each respective bullet.