Skip to content

Release for repo.sourcify.dev #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Apr 28, 2025
Merged

Release for repo.sourcify.dev #3

merged 62 commits into from
Apr 28, 2025

Conversation

kuzdogan
Copy link
Member

This release implements the changes laid out in ethereum/sourcify#1997

Some of the rationale of the decisions are made are also stated under each respective bullet.

@kuzdogan kuzdogan moved this to Sprint - Needs Review in Sourcify Public Apr 23, 2025
Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here a list of unresolved issues:

  • Improve padding of sections' title (now it's 0)

    still not solved
    image

  • open in remix is not working, idk if I'm doing something wrong. When I click the button, remix opens with a banner on the bottom "initiating contract-verification/lookupAndSave and calling "sourcify" ...", but then nothing happens.

  • Copy and download buttons for editors
    there is no copy button

Then this is a list of other issues I found:

  • We should add a label if there are no transformations "There are no transformations" or remove the transformation section if it's empty. It doesn't always happens, sometimes it exists empty, sometimes there is no section
    image

Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, while testing some changes in the files I noticed that the files are not formatted via prettier.

@kuzdogan
Copy link
Member Author

kuzdogan commented Apr 25, 2025

Improve padding of sections' title (now it's 0)

still not solved
image

What's the issue here? I can't understand. It's properly padded

open in remix is not working

Yeah another / was needed in another place, good catch.

Copy and download buttons for editors

Added everywhre except bytecodes

We should add a label if there are no transformations

Good catch again. It was because we forgot the "CBORAuxdataTransformations" in creation bytecode

@kuzdogan
Copy link
Member Author

This was what I was seeing on Chrome vs Firefox

Chrome
image

Firefox
image

@kuzdogan
Copy link
Member Author

Done fixes can you please double check? I think we are on the same page now @marcocastignoli

Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow so clean! Great job! 🎉

@kuzdogan kuzdogan merged commit 247236e into main Apr 28, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Sprint - Needs Review to Sprint - Done in Sourcify Public Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants