gitserver: Remove unnecessary redaction #62782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/05-18-gitserverremoveunnecessaryredaction
branch
from
c0f99b8
to
3b139dd
Compare
The syncer implementation already does redaction based on the remote URL it actually used, so this is redundant, and an unnecessary call to the database / KMS backend. Test plan: Code review, CI passes.
eseliger
force-pushed
the
es/05-18-gitserverremoveunnecessaryredaction
branch
from
3b139dd
to
8116243
Compare
ggilmore
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syncer implementation already does redaction based on the remote URL it actually used, so this is redundant, and an unnecessary call to the database / KMS backend.
Test plan:
Code review, CI passes.