gitserver: Sunset Exec endpoint #62774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
github-actions
bot
added
team/product-platform
team/source
ggilmore
approved these changes
May 20, 2024
eseliger
force-pushed
the
es/05-17-gitserverdeprecateexecandremovelocalgit
branch
from
7f51c08
to
858cb3d
Compare
eseliger
force-pushed
the
es/05-17-gitserversunsetexecendpoint
branch
from
45db510
to
3e86bd6
Compare
eseliger
force-pushed
the
es/05-17-gitserverdeprecateexecandremovelocalgit
branch
from
858cb3d
to
44b9087
Compare
Base automatically changed from
es/05-17-gitserverdeprecateexecandremovelocalgit
to
main
May 21, 2024 16:19
eseliger
force-pushed
the
es/05-17-gitserversunsetexecendpoint
branch
from
3e86bd6
to
d0fbdc8
Compare
After we finally migrated all calls to Exec by proper API offerings, we're finally not using this API anymore. The previous PR deprecated this endpoint, and this one will fully remove it. We can merge it early June when after the next release was cut. As a result of this, gitserver no longer exposes a blanket exec endpoint that could pose several risks from running dangerous commands to just running commands that could cause resource exhaustion. Test plan: This endpoint is unused, CI did not find any issues from removing it.
eseliger
force-pushed
the
es/05-17-gitserversunsetexecendpoint
branch
from
d0fbdc8
to
1708397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we finally migrated all calls to Exec by proper API offerings, we're finally not using this API anymore.
The previous PR deprecated this endpoint, and this one will fully remove it. We can merge it early June when after the next release was cut.
As a result of this, gitserver no longer exposes a blanket exec endpoint that could pose several risks from running dangerous commands to just running commands that could cause resource exhaustion.
Closes #62099
Test plan:
This endpoint is unused, CI did not find any issues from removing it.