fix(chat): remove current selection from initial mention #7161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression from #7115, which aims to remove the current selection from being added as part of initial mentions chips in first message, but removed the option completely by mistake. - Adding the current text selection as a context item provided to the chat webview, but removes it from the initial at-mention context chips ## Test Plan Selection Behavior Tests Select code in the editor and start a new chat Verify the selection is NOT shown in the initial @-mention chips Verify the selection IS available as context in the chat webview Regression Prevention Tests Start a chat without any selection Start a chat with multiple selections Verify @-mention chips work correctly in both cases Integration Tests Test interaction between selection and other context sources Verify selection context is properly passed to the chat backend Edge Cases Test with very large selections Test with multi-line selections Test with selections containing special characters UI Verification Verify the chat UI correctly displays the context without the initial selection in chips Verify the selection can still be referenced in follow-up messages
arafatkatze
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
The selection not being present in the new chat behavior has been verified.
NOTE: when you have an existing chat and if you click on Opt+L it would toggle rather than start a new chat. IF that's the expected behavior(instead of new chat) then this PR is okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression from #7115, which aims to remove the current selection from being added as part of initial mentions chips in first message, but removed the option completely by mistake.
Test plan