Skip to content

Maybe next year #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ module.exports = {
coverageThreshold: {
global: {
branches: 55,
functions: 70,
lines: 75,
functions: 75,
lines: 80,
statements: 75,
},
},
Expand Down
2 changes: 1 addition & 1 deletion src/bot/__tests__/requestReview.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ describe('requestReview', () => {
expect(param.ack).toBeCalled();
});

it.skip('should post a message to the interviewing channel', async () => {
it('should post a message to the interviewing channel', async () => {
const { param } = await callCallback();

expect(param.client.chat.postMessage).toBeCalledWith({
Expand Down
3 changes: 1 addition & 2 deletions src/bot/requestReview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { QueueService } from '@services';
import { App, Block, KnownBlock, PlainTextOption, View } from '@slack/bolt';
import { blockUtils } from '@utils/blocks';
import log from '@utils/log';
import { bold, codeBlock, compose, italic, mention, ul, link } from '@utils/text';
import { bold, codeBlock, compose, italic, mention, ul } from '@utils/text';
import { PendingReviewer } from '@models/ActiveReview';
import { ActionId, Deadline, DeadlineLabel, Interaction } from './enums';
import { chatService } from '@/services/ChatService';
Expand Down Expand Up @@ -216,7 +216,6 @@ export const requestReview = {
)} has requested ${numberOfReviewersValue} reviews for a HackerRank done in the following languages:`,
ul(...languages),
bold(`The review is needed by end of day ${deadlineDisplay}`),
link('AI-Powered Plagiarism Review', 'https://www.youtube.com/watch?v=dQw4w9WgXcQ'),
candidateIdentifierValue ? italic(`Candidate Identifier: ${candidateIdentifierValue}`) : '',
),
);
Expand Down
2 changes: 1 addition & 1 deletion src/services/__tests__/ChatService.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('ChatService', () => {
});
});

describe.skip('sendRequestReviewMessage', () => {
describe('sendRequestReviewMessage', () => {
it('should notify the given user that a request is ready for them to review', async () => {
const client = buildMockWebClient();
client.chat.postMessage = jest.fn().mockResolvedValue({
Expand Down
3 changes: 1 addition & 2 deletions src/utils/RequestBuilder.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ActionId, BlockId } from '@bot/enums';
import { bold, compose, link, mention, ul } from '@utils/text';
import { bold, compose, mention, ul } from '@utils/text';
import { ActionsBlock, Block } from '@slack/bolt';
import { SectionBlock } from '@slack/types';

Expand Down Expand Up @@ -47,7 +47,6 @@ export const requestBuilder = {
)} has requested a HackerRank review done in the following languages:`,
ul(...languages),
bold(`The review is needed by end of day ${deadlineDisplay}`),
link('AI-Powered Plagiarism Review', 'https://www.youtube.com/watch?v=dQw4w9WgXcQ'),
),
},
};
Expand Down
4 changes: 0 additions & 4 deletions src/utils/text.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ export function li(...items: string[]): string {
return items.map((item, index) => ` ${index + 1}. ${item}`).join('\n');
}

export function link(linkText: string, url: string) {
return `<${url}|${linkText}>`;
}

export function codeBlock(...lines: string[]): string {
return ['```', ...lines, '```'].join('\n');
}
Expand Down