-
Notifications
You must be signed in to change notification settings - Fork 174
CP3108 SR AI-powered marking #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix redux state not saving issue
Comment selector can now handle selecting multiple suggestions
…nto eugene-grading-comment-selector
This reverts commit 780a269.
Pull Request Test Coverage Report for Build 19938701985Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a backend PR to accompany this frontend PR?
This is the accompanying backend PR: |
|
@sentry review |
src/pages/academy/grading/subcomponents/GradingCommentSelector.tsx
Outdated
Show resolved
Hide resolved
…cademy/frontend into eugene-grading-comment-selector
|
LLM Key should never be put in session state, let alone persisted, let alone in the frontend. Paste the plain text once upon course creation, it's sent to BE and encrypted forever (you can't view it again). You should not be able to view it again, only change it subsequently via the dialog. |
…cademy/frontend into eugene-grading-comment-selector
src/pages/academy/adminPanel/subcomponents/CourseConfigPanel.tsx
Outdated
Show resolved
Hide resolved
src/pages/academy/adminPanel/subcomponents/CourseConfigPanel.tsx
Outdated
Show resolved
Hide resolved
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! Let's try this out and fix bugs if any are to be discovered
Description
Creates a generate AI comments field in the Grading editor and workspace, also includes fields to enable LLM Grading and add a course specific API key in the course configuration panels.
Type of change
How to test
Nil. I don't know how to test frontend, do advise on what I should include.
Checklist
Do advise as well on how to update the documentation. Thanks