Skip to content

Conversation

@jcastill
Copy link
Member

@jcastill jcastill commented Jul 7, 2025

This commit creates the plugin for RHEL Lightspeed Command Line Assistant.

Related: RSPEED-549, RHEL-102037


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@jcastill
Copy link
Member Author

jcastill commented Jul 7, 2025

Work in progress for now. I'm reviewing what needs to be obfuscated (for now, only db passwords, but waiting for confirmation) and log captures.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4070
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

services = ('clad',)

def setup(self):
self.add_copy_spec("/etc/xdg/command-line-assistant/config.toml")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T see the file has (commented out by default, unsure if supported) options:

# In order to use postgresql, uncomment the following settings:
# [database]
# type = "postgresql"
# host = "localhost"
# port = "5432"
# username = "your-user"
# password = "your-password"
# database = "history"

# Or, to use mysql, uncomment the following:
# [database]
# type = "mysql"
# host = "localhost"
# port = "3306"
# username = "your-user"
# password = "your-password"
# database = "history"

so shall we scrub passwords from it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passwords for sure, but I'm waiting to see if something else needs to be scrubbed. Do you prefer if I add the postproc now and expand it later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let add it later, no need now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to push a new change with the updated commands requested in the new ticket, and I'll start working on obfuscating the passwords.
I'll leave this PR still in draft because we need to discuss the database collection

@jcastill jcastill force-pushed the jcastillo-lightspeed-cla branch from d81a715 to 0a7f3ca Compare October 20, 2025 09:14
def setup(self):
self.add_copy_spec([
"/etc/xdg/command-line-assistant/config.toml",
"/var/lib/command-line-assistant/history.db",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth putting this under a plugopt, disabled by default - it can contain some potentially sensitive information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both files, or just the db?
I imagine just the db, and for the config I can add the usual obfuscation of passwords, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

This commit creates the plugin for RHEL Lightspeed
Command Line Assistant.

Related: RSPEED-549, RHEL-102037, RHEL-122242

Signed-off-by: Jose Castillo <[email protected]>
@jcastill jcastill force-pushed the jcastillo-lightspeed-cla branch from 0a7f3ca to 583fc53 Compare October 24, 2025 09:34
@arif-ali
Copy link
Member

This is still in draft, is this reviewable?

@jcastill
Copy link
Member Author

@arif-ali if you have the bandwith then yes, please.
It's in draft because we are waiting for internal testing and the original reporter to answer some questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants