-
Notifications
You must be signed in to change notification settings - Fork 595
[lightspeed] Add new plugin for RH Lightspeed #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Work in progress for now. I'm reviewing what needs to be obfuscated (for now, only db passwords, but waiting for confirmation) and log captures. |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
sos/report/plugins/lightspeed.py
Outdated
| services = ('clad',) | ||
|
|
||
| def setup(self): | ||
| self.add_copy_spec("/etc/xdg/command-line-assistant/config.toml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T see the file has (commented out by default, unsure if supported) options:
# In order to use postgresql, uncomment the following settings:
# [database]
# type = "postgresql"
# host = "localhost"
# port = "5432"
# username = "your-user"
# password = "your-password"
# database = "history"
# Or, to use mysql, uncomment the following:
# [database]
# type = "mysql"
# host = "localhost"
# port = "3306"
# username = "your-user"
# password = "your-password"
# database = "history"
so shall we scrub passwords from it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passwords for sure, but I'm waiting to see if something else needs to be scrubbed. Do you prefer if I add the postproc now and expand it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let add it later, no need now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to push a new change with the updated commands requested in the new ticket, and I'll start working on obfuscating the passwords.
I'll leave this PR still in draft because we need to discuss the database collection
d81a715 to
0a7f3ca
Compare
sos/report/plugins/lightspeed.py
Outdated
| def setup(self): | ||
| self.add_copy_spec([ | ||
| "/etc/xdg/command-line-assistant/config.toml", | ||
| "/var/lib/command-line-assistant/history.db", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth putting this under a plugopt, disabled by default - it can contain some potentially sensitive information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both files, or just the db?
I imagine just the db, and for the config I can add the usual obfuscation of passwords, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!
This commit creates the plugin for RHEL Lightspeed Command Line Assistant. Related: RSPEED-549, RHEL-102037, RHEL-122242 Signed-off-by: Jose Castillo <[email protected]>
0a7f3ca to
583fc53
Compare
|
This is still in draft, is this reviewable? |
|
@arif-ali if you have the bandwith then yes, please. |
This commit creates the plugin for RHEL Lightspeed Command Line Assistant.
Related: RSPEED-549, RHEL-102037
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines