Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Check if a path exists inside a container in add_dir_listing() #3805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcastill
Copy link
Member

Currently, add_dir_listing() checks if a path exists outside of a container, and when we call the command for a container, it fails to collect any listing. This patch adds a new function container_path_exists() that checks for the specified path in add_dir_listing() inside the container.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Currently, add_dir_listing() checks if a path exists outside of a
container, and when we call the command for a container, it fails to
collect any listing. This patch adds a new function
container_path_exists() that checks for the specified path in
add_dir_listing() inside the container.

Signed-off-by: Jose Castillo <[email protected]>
:returns: True if the path exists in the container, else False
:rtype: ``bool``
"""
return self.exec_cmd(f"test -e {path}", container=container)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there are better ways to do this, but I didn't find any way in our code already, so I had to come up with this 'dirty' trick.
As always, open to suggestions to do this in a better way :)

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3805
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Contributor

@pmoravec pmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK in general. I would expect there is more elegant solution than the self.exec_cmd(f"test -e {path}", container=container) but I cant find any /o.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants