Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foreman] [foreman_proxy] Add ALL_PROXY and NO_PROXY to collected env_vars #3792

Closed
wants to merge 0 commits into from

Conversation

pafernanr
Copy link
Contributor

Add ALL_PROXY and NO_PROXY to collected env_vars

Resolves: #3788

Signed-off-by: Pablo Fernández Rodríguez [email protected]

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [ x] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ x] Is the subject and message clear and concise?
  • [ x] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [x ] Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • [ x] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • [x ] Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3792
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

sos/report/plugins/foreman.py Outdated Show resolved Hide resolved
sos/report/plugins/foreman_proxy.py Outdated Show resolved Hide resolved
sos/report/plugins/foreman.py Fixed Show fixed Hide fixed
sos/report/plugins/foreman_proxy.py Fixed Show fixed Hide fixed
@jcastill
Copy link
Member

@pafernanr looks good to me, but can you squash them all together?

@pafernanr
Copy link
Contributor Author

@jcastill thanks for your tips.

@arif-ali
Copy link
Member

@pafernanr can you squash the commits, so that we only see one commit please. That's what @jcastill was suggesting

Copy link
Contributor

@pmoravec pmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK to the change itself.

Just the commit contains also one commit from main :-o and manual merge must be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

most plugins doesn't collect ALL_PROXY environment variable
4 participants