-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[man] Fix man page lintian issues #3703
[man] Fix man page lintian issues #3703
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
f424726
to
6665b1e
Compare
man/en/sos-report.1
Outdated
@@ -313,7 +313,7 @@ a timeout for a specific plugin, use the 'timeout' plugin option available to | |||
all plugins - e.g. '-k logs.timeout=600'. | |||
|
|||
The plugin-specific timeout option will override this option. For example, using | |||
\'--plugin-timeout=60 -k logs.timeout=600\' will set a timeout of 600 seconds for | |||
'--plugin-timeout=60 -k logs.timeout=600' will set a timeout of 600 seconds for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came up with the following issue, and hence the change
I: sosreport: acute-accent-in-manual-page [usr/share/man/man1/sos-
report.1.gz:313]
N:
N: This manual page uses the \' groff sequence. Usually, the intent is to
N: generate an apostrophe, but that sequence actually renders as an acute
N: accent.
N:
N: For an apostrophe or a single closing quote, use plain '. For single
N: opening quote, i.e. a straight downward line ' like the one used in
shell
N: commands, use '\(aq'.
N:
N: In case this tag was emitted for the second half of a '\\' sequence,
this
N: is indeed no acute accent, but still wrong: A literal backslash should
be
N: written \e in the groff format, i.e. a '\\' sequence needs to be changed
N: to '\e' which also won't trigger this tag.
N:
N: Please refer to Bug#554897, Bug#507673, and Bug#966803 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: acute-accent-in-manpage
N:
N:
I: sosreport: acute-accent-in-manual-page
[usr/share/man/man1/sosreport.1.gz:313]
Below is what was seen in the man page
using ´--plugin-timeout=60 -k logs.timeout=600´ will
6665b1e
to
4ca12a7
Compare
This was reported as part of deb packaging in Debian. Signed-off-by: Arif Ali <[email protected]>
4ca12a7
to
afa7597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix with the \aq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow why the underscores are needed? The commands are sos (space) $component
, and the underscore to me implies that they would be separate commands e.g. sos_clean
, sos_collect
, etc...
Below were the 2 warning outputs from lintian, and hence updated it, based on this (See Debian bugs #1076253 and #1076347 for full details) bad-whatis-entry
wrong-manual-section
|
You'll also see the lint messages in the other PR (I still need to fine-tune that PR to fix a few things), and here's the log for that https://api.cirrus-ci.com/v1/task/4983139397795840/logs/main.log (Draft PR #3709) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang, I really dislike the reasoning behind the required use of underscores to an extreme degree, but it is what it is I guess.
This was reported as part of deb packaging in Debian.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines