Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[greenboot] seperate logs to a standalone plugin. #3352

Merged
merged 1 commit into from
Sep 16, 2023
Merged

[greenboot] seperate logs to a standalone plugin. #3352

merged 1 commit into from
Sep 16, 2023

Conversation

eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Sep 7, 2023 •
edited
Loading

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@eslutsky eslutsky changed the title greenboot seperate logs to a standalone package. greenboot seperate logs to a standalone plugin. Sep 7, 2023
@eslutsky eslutsky changed the title greenboot seperate logs to a standalone plugin. [greenboot] seperate logs to a standalone plugin. Sep 7, 2023
@eslutsky eslutsky force-pushed the seperate_greenboot branch 2 times, most recently from c4e4157 to c6bf6b0 Compare September 7, 2023 08:00
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3352
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@eslutsky eslutsky changed the title [greenboot] seperate logs to a standalone plugin. [greenboot] seperate journal logs to a standalone plugin. Sep 7, 2023
arif-ali
arif-ali requested changes Sep 7, 2023
View reviewed changes
sos/report/plugins/greenboot.py Outdated Show resolved Hide resolved
@pmoravec
Copy link
Contributor

pmoravec commented Sep 8, 2023

Commit message speaks about journal logs, but the change would collect just a config file - do I miss something..?

@bmr-cymru
Copy link
Member

Commit message for a plugin wants to be something like [greenboot] separate logs to a standalone plugin.

dhellmann
dhellmann reviewed Sep 12, 2023
View reviewed changes
sos/report/plugins/greenboot.py Outdated
short_desc = 'Greenboot'
plugin_name = 'greenboot'
plugin_timeout = 300
packages = ('microshift-greenboot',)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want to tie this to MicroShift.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhellmann , greenboot is distributed as microshift-greenboot rpm, are we going to change that also?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The microshift-greenboot RPM contains the scripts for MicroShift to integrate with greenboot, but the actual system software is in the greenboot RPM.

@eslutsky eslutsky changed the title [greenboot] seperate journal logs to a standalone plugin. [greenboot] seperate logs to a standalone plugin. Sep 13, 2023
@eslutsky eslutsky force-pushed the seperate_greenboot branch 3 times, most recently from 5c7d1c6 to 62c7f40 Compare September 13, 2023 14:27
TurboTurtle
TurboTurtle reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however this needs to be rebased on current main as there is now a merge conflict based upon another change to the microshift plugin (minor change to the services tuple).

Once that's done, this should be good. Note 4.6.1 is scheduled to close tomorrow.

@eslutsky
Copy link
Contributor Author

LGTM, however this needs to be rebased on current main as there is now a merge conflict based upon another change to the microshift plugin (minor change to the services tuple).

Once that's done, this should be good. Note 4.6.1 is scheduled to close tomorrow.

ACK and done .

@TurboTurtle TurboTurtle merged commit 765ac8f into sosreport:main Sep 16, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmoravec pmoravec pmoravec left review comments

@dhellmann dhellmann dhellmann left review comments

@TurboTurtle TurboTurtle TurboTurtle approved these changes

@arif-ali arif-ali arif-ali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eslutsky @pmoravec @bmr-cymru @dhellmann @arif-ali @TurboTurtle