[report] Don't use sysroot for network device enumeration #3313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sos is being used in a live environment to diagnose an issue, using sysroot can cause the network device enumeration via /sys/class/net crawling to fail. This will be the case for systems that do not use
nmcli
.When in a live environment, network devices will not be under
/$sysroot/sys/class/net
but the "regular" path for the booted environment. Similarly, if sos is being run in a container that is properly configured, network devices will appear under/sys/class/net
and not (necessarily) under the sysroot path that mounts the host's filesystem.As such, disregard a configured sysroot when enumerating network devices by crawling
/sys/class/net
, and trap any exceptions that may percolate up from this in edge case environments.Closes: #3307
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines