Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[options] compatibility fix for python 3.12 #3309

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

sandrobonazzola
Copy link
Contributor

Addresses ConfigParser.readfp removal in 3.12.

Fixes #3308

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2223526


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Addresses ConfigParser.readfp removal in 3.12.

Fixes #3308

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2223526
Signed-off-by: Sandro Bonazzola <[email protected]>
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3309
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jcastill
Copy link
Member

LGTM

I don't think the centos-stream-8 failed test is a big problem, we can try to restart it and see if it completes again.

@TurboTurtle
Copy link
Member

I've restarted the CI jobs, failure was unrelated.

@TurboTurtle TurboTurtle merged commit 97bc495 into sosreport:main Jul 19, 2023
@sandrobonazzola sandrobonazzola deleted the bz2223526 branch July 19, 2023 15:01
Copy link

@tiredPotato tiredPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.12: sos crashes because of ConfigParser
5 participants