Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lustre] Add more debug params #3304

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

utopiabound
Copy link
Contributor

This prevents mb_groups from being collected as it is large, and not useful for debug.
This also collects more state of the filesystem.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3304
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utopiabound can you look at the flake8 linting test please, other than that lgtm

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a pure code perspective, but the pep8 violations need to be addressed before we merge this.

@utopiabound
Copy link
Contributor Author

I used black -l 80 to reformat, it now passes flake8

@TurboTurtle
Copy link
Member

I used black -l 80 to reformat, it now passes flake8

That seems to have introduced a whole slew of other changes that makes groking the actual changes for this PR rather murky. It also breaks the style we use for list indentations (see style guidelines) - here for instance.

This prevents mb_groups from being collected as it is large, and not
useful for debug.
This also collects more state of the filesystem.

Signed-off-by: Nathaniel Clark <[email protected]>
@utopiabound
Copy link
Contributor Author

I used black -l 80 to reformat, it now passes flake8

That seems to have introduced a whole slew of other changes that makes groking the actual changes for this PR rather murky. It also breaks the style we use for list indentations (see style guidelines) - here for instance.

Sorry, fixed.

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the CI test issues are unrelated to the change now

@TurboTurtle TurboTurtle merged commit cdf78fe into sosreport:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants