-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lustre] Add more debug params #3304
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utopiabound can you look at the flake8 linting test please, other than that lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine from a pure code perspective, but the pep8 violations need to be addressed before we merge this.
I used |
That seems to have introduced a whole slew of other changes that makes groking the actual changes for this PR rather murky. It also breaks the style we use for list indentations (see style guidelines) - here for instance. |
This prevents mb_groups from being collected as it is large, and not useful for debug. This also collects more state of the filesystem. Signed-off-by: Nathaniel Clark <[email protected]>
c4d5ebb
to
10528b2
Compare
Sorry, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the CI test issues are unrelated to the change now
This prevents mb_groups from being collected as it is large, and not useful for debug.
This also collects more state of the filesystem.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines