k8s e.g.: Enable high availablility by NOT collocating pods on the same node#741
Open
Miyurz wants to merge 1 commit intosorintlab:masterfrom
Open
k8s e.g.: Enable high availablility by NOT collocating pods on the same node#741Miyurz wants to merge 1 commit intosorintlab:masterfrom
Miyurz wants to merge 1 commit intosorintlab:masterfrom
Conversation
With this change, we ensure that the replica pods of the same deployment do not get assigned to the same node. Fot this, we have employed k8s anti-affinity rule.
|
@sgotti Can you please review ? |
sgotti
requested changes
Dec 11, 2019
Member
sgotti
left a comment
There was a problem hiding this comment.
@Miyurz Thanks for your PR.
Since this is just a k8s example I'd like to avoid making it more complex as needed. Additionally if people wants to test it on minikube or another single node k8s cluster this change will make it impossible to test.
So we can add this but make it commented out with a heading comment that describes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, we ensure that the replica pods of the same
deployment do not get assigned to the same node. Fot this, we have
employed k8s anti-affinity rule.