Print out diff in sentinel test if it fails.#679
Open
arssher wants to merge 1 commit intosorintlab:masterfrom
Open
Print out diff in sentinel test if it fails.#679arssher wants to merge 1 commit intosorintlab:masterfrom
arssher wants to merge 1 commit intosorintlab:masterfrom
Conversation
Makes eyeballing of test failures easier...
Open
lawrencejones
requested changes
Sep 3, 2019
Contributor
lawrencejones
left a comment
lawrencejones
left a comment
There was a problem hiding this comment.
Hey @arssher!
I think this is a great idea, as the sentinel tests can be difficult to debug right now.
I don't think we should be vendoring our own diffing code though. I'd far prefer we use a library that provides diffing, such as https://github.com/google/go-cmp.
Can you adjust this PR to do that instead? Then I'd be happy to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes eyeballing of test failures easier...
Extracted from pull request #622.