Allow configuring RegEx patterns for copySourcePRLabels
#529
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we only allow copying over either all or no labels. With this commit, we also allow specifying a list of RegEx patterns that will be used to conditionally copy over labels. This is useful when you don't want to copy over all labels, but you also don't want to manually specify every time which labels you want to be copied over.
nielsbauman
commented
Mar 24, 2025
| @@ -31,7 +31,7 @@ type Options = Partial<{ | |||
| cherrypickRef: boolean; | |||
| commitConflicts: boolean; | |||
| commitPaths: string[]; | |||
| copySourcePRLabels: boolean; | |||
| copySourcePRLabels: boolean | string[]; | |||
There was a problem hiding this comment.
I wasn't able to figure out a way to make this change in cliArgs.ts. We could also define a new option instead of allowing two types in the existing option, if that's preferred. Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only allow copying over either all or no labels. With this commit, we also allow specifying a list of RegEx patterns that will be used to conditionally copy over labels.
This is useful when you don't want to copy over all labels, but you also don't want to manually specify every time which labels you want to be copied over.