Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent example from failing on unmerged PRs #133

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Prevent example from failing on unmerged PRs #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db076d
Prevent example from failing on unmerged PRs
Krzmbrzl Jul 6, 2024
4f3d732
Also don't run README example on backport PRs
Krzmbrzl Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
jobs:
backport:
name: Backport PR
if: github.event.pull_request.merged == true && !(contains(github.event.pull_request.labels.*.name, 'backport'))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the workflow will only be triggered when the PR is merged and does NOT contain the backport label. Should it be when it's merged and DOES contain the label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - backport is the default label the tool assigns to backport PRs for which we don't want to run the tool again (e.g. no backport of the backport)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misunderstood. That makes sense.

runs-on: ubuntu-latest
steps:
- name: Backport Action
Expand Down
Loading