Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rails method signatures #389

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix rails method signatures #389

wants to merge 3 commits into from

Conversation

iloveitaly
Copy link
Contributor

These incorrect method signatures were causing the rbis for the corresponding gems to be untyped. This fixes the typing issue for me.

@iloveitaly iloveitaly requested a review from a team as a code owner January 12, 2022 22:52
@iloveitaly iloveitaly requested review from elliottt and removed request for a team January 12, 2022 22:52
jez
jez requested changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got some test failures.

@elliottt elliottt removed their request for review January 20, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iloveitaly @jez