Allow path => controller#action in Routes

[panthomakos]

The 'path' => 'controller#action' is a supported short-hand syntax
for Rails routes as documented here. The current type is too
restrictive and does not support this valid syntax. This change modifies
the first argument type so that it supports the Hash syntax.

[panthomakos]

Might be worth considering adding a test-suite for some of these routes. For example, a simple routes.rb file with some variations that could be type-checked.

[connorshea]

Yup, that's what #42 is for. Though I suppose we could still have files that use the library and make sure all valid input is allowed 🤔 That shouldn't be as hard as porting the test harness over to this repo.

[panthomakos]

I rebased on master and included tests that fail before the change:

lib/actionpack/test/actionpack_test.rb:40: Expected T.any(String, Symbol) but found {String("about") => String("static_pages#about")} for argument name https://srb.help/7002
    40 |  get 'about' => 'static_pages#about'
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    lib/actionpack/all/actionpack.rbi:151: Method ActionDispatch::Routing::Mapper::HttpHelpers#get has specified name as T.any(String, Symbol)
     151 |      name: T.any(String, Symbol),
                ^^^^
  Got {String("about") => String("static_pages#about")} originating from:
    lib/actionpack/test/actionpack_test.rb:40:
    40 |  get 'about' => 'static_pages#about'
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Errors: 1

[DarkDimius]

Awesome, thank you for the tests!