Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings update before workspace/didChangeConfiguration notification #50

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fix settings update before workspace/didChangeConfiguration notification #50

merged 1 commit into from
Jul 14, 2024

Conversation

agorgl
Copy link
Contributor

@agorgl agorgl commented May 30, 2024

Fixes #49, #45, #48

vlada-dudr
vlada-dudr approved these changes Jun 10, 2024
View reviewed changes
Copy link

@vlada-dudr vlada-dudr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me.

@umlx5h
Copy link

umlx5h commented Jul 1, 2024

@someone-stole-my-name
ping

@agorgl
Copy link
Contributor Author

agorgl commented Jul 6, 2024

@someone-stole-my-name can we merge this?

@agorgl agorgl mentioned this pull request Jul 6, 2024
Open
@rgroemmer
Copy link

nice work @agorgl, im running from your branch and it works for now.
Happy to see this merged :)

@someone-stole-my-name someone-stole-my-name self-assigned this Jul 14, 2024
@someone-stole-my-name someone-stole-my-name merged commit 131b0d6 into someone-stole-my-name:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlada-dudr vlada-dudr vlada-dudr approved these changes

@someone-stole-my-name someone-stole-my-name someone-stole-my-name approved these changes

Assignees

@someone-stole-my-name someone-stole-my-name

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: client settings do not change correctly before workspace/didChangeConfiguration lsp notification
5 participants
@agorgl @umlx5h @rgroemmer @vlada-dudr @someone-stole-my-name