Tweak/misc nonunit #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
tweak/misc-nonunit
branch
from
5df954b to
4c1a725
Compare
The previous tweak to take `if (_)` as `if (_: Boolean)` is too strict.
That disallowed
BooleanSetting().("-nowarn").withPostSetHook(if(_) maxwarns.value=0)
REPL handles assignment ops like Assign
ScalaCheck 1.18.0 (was 1.17.0)
…imports Avoid unused import in REPL
Defer infer bool param
Adjust keepAlive for test under JDK 9 [ci: last-only]
…rp-dollar Better split for missing-interpolator
This change adds a new flag `-Ycollect-statistics` that enables the same statistics gathering as `-Ystatistics` but without dumping all the statistics to the console. This is useful for build tools that want to collect statistics via a compiler plugin without interfering with the console output or the operation of `-Ystatistics` (if specified explicitly by the user). Note that there is an internal `YstatisticsEnabled` setting that may appear to do this already, but in fact it controls both collecting and printing together. Even if you switched it on internally (without enabling any phase statistics via `-Ystatistics` / `-Yhot-statistics`) you would still get at least the phase timings summary.
Collect statistics without printing them
RefinementClassSymbols are created ad hoc for types in asSeenFrom, two symbols with the same parents don't compare `isSubClass`.
Rewrite phase assembly (`DependencyGraph`) [ci: last-only]
This PR adds a new `-system` / `--system` setting to scalac which mimics its counterpart in javac. This fixes the biggest problem (at least for us) of scala/bug#13015. It is now possible to compile code against an older system image without enforcing strict module access. scalac generally does not enforce modules (scala/scala-dev#529) but it does when using `-release` (with class lookup based on `ct.sym`) and there was no way to opt out of these restrictions. The usual opt-out in javac is `--add-exports` but it is not supported for system modules in combination with `--release` (https://bugs.openjdk.org/browse/JDK-8178152) so there is no expectation that scalac could support it. Instead the solution for javac is to replace `--release` with a combination of `-source`, `-target` and a system image for the target version via `--system`. This combination, unlike `--release`, can be used with `--add-exports`. If scalac adds full module support at a later time (with access restrictions enabled by default) it will also need to support `--add-exports` and allow its use in combination with `--system`. I am also un-deprecating `-target` (which was deprecated in favor of `-release`) because it now has a legitimate use in combination with an alternative system image (just like in javac where it serves the same purpose and is not deprecated, either).
Backport of scala#10795: This change adds a new flag `-Ycollect-statistics` that enables the same statistics gathering as `-Ystatistics` but without dumping all the statistics to the console. This is useful for build tools that want to collect statistics via a compiler plugin without interfering with the console output or the operation of `-Ystatistics` (if specified explicitly by the user). Note that there is an internal `YstatisticsEnabled` setting that may appear to do this already, but in fact it controls both collecting and printing together. Even if you switched it on internally (without enabling any phase statistics via `-Ystatistics` / `-Yhot-statistics`) you would still get at least the phase timings summary.
Fix tasty test check files ignore trailing whitespace in tasty diffs Co-authored-by: A. P. Marki <[email protected]> Co-authored-by: Jamie Thompson <[email protected]>
REPL: JLine: stop using deprecated JNA
Co-authored-by: Lukas Rytz <[email protected]>
…a-result Improve result of bridge in delambdafy
Build cleanup: use `withTag`
Backport Java parse annots fix
fix procedure syntax in build file
sbt 1.10.5 (was .3)
Generate `AbstractZincFile` during `-sourcepath` workflow
since it doesn't add any information that is actually specific to the `Ordering` type; and to prevent the message from also being used for `Numeric` (a subtype of `Ordering`) fixes scala/bug#13053
Fix but ignore exploding test
…named-arg Deprecate infix named args [ci: last-only]
…1105 Merge 2.12.x to 2.13.x [ci: last-only]
sensible equals warning: strings and collections
Don't insert box instructions around label jumps
Document invisibility of `BeanProperty` methods from Scala 3
remove @implicitNotFound on Ordering
som-snytt
force-pushed
the
tweak/misc-nonunit
branch
from
4c1a725 to
aae7e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.