Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and Edit Product Property with UI components issue #5857 #5892

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Astr0surf3r
Copy link

@Astr0surf3r Astr0surf3r commented Oct 31, 2024

Summary

fix the issue #5857

Now to add a product property appear a modal

window-new-property Screenshot 2024-10-30 at 5 26 26 p m

And to edit a Property appear a modal as well

window-edit-property success-updated

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

@Astr0surf3r Astr0surf3r requested a review from a team as a code owner October 31, 2024 00:36
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_admin labels Oct 31, 2024
@Astr0surf3r Astr0surf3r changed the title Create and Edit Product Property with UI components #5857 Create and Edit Product Property with UI components issue #5857 Oct 31, 2024
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Astr0surf3r You have not followed our pull request guidelines:

  • The commit messages lack any explanation.
  • Some commits add unnecessary code that gets removed by later commits.
  • Linting changes shouldn't be in separate commits and your linting commit also removes unneeded code.

I'd appreciate a rebase of this PR to address these issues.

@MadelineCollier Can you take a pass over this from an implementation perspective and make sure it's consistent with how similar features are built? You have better knowledge of how admin features should be built.

def form_id
dom_id(@property, "#{stimulus_id}_edit_property_form")
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is mostly misindented.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarednorman thank you for your message I have just already made rebase in this PR and follow the solidus guideline let me know if need a cleaner PR I can upload 1 single commit with all changes ... let me know please

@Astr0surf3r Astr0surf3r force-pushed the create-edit-product-property branch 3 times, most recently from c399ad5 to 042abb4 Compare November 2, 2024 00:11
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Nov 2, 2024
@github-actions github-actions bot removed changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.61%. Comparing base (78e5f28) to head (23c1b84).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...controllers/solidus_admin/properties_controller.rb 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5892      +/-   ##
==========================================
+ Coverage   89.58%   89.61%   +0.02%     
==========================================
  Files         783      785       +2     
  Lines       17989    18049      +60     
==========================================
+ Hits        16116    16174      +58     
- Misses       1873     1875       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants