-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin][Product] fix properties edit action in admin panel part of the issue #5857 #5885
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Would you mind to update the link instead. We do not have show actions anywhere. We only ever have edit actions. By updating the link to the edit route it should be fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5885 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 783 783
Lines 17994 17994
=======================================
Hits 16113 16113
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
@Astr0surf3r please use rebase to update your branch as mentioned in the contribution guidelines |
@tvdeyen I hope now the PR is cleaner than before ... if need something else to do (I have read the guidelines) let me know please I really appreciate all your tips and messages to give a hand to your great project NOTE: now the PR is out-of-date with the base branch for this reason launched an |
Summary
I have just downloaded the gem to fix the issue #5857 and I found in admin panel an error in Property Types (in your demo the error appear as well)
After I added a new one property and no issue came up clicking in the
+ Add new
button of the/admin/properties
pagebut after I saved it
I couldn't edit it because an error appear
so to fix this I add the show action in the
Spree::Admin::PropertiesController
and create an rspec file I hope this can help your great workI have written a thorough PR description.
I have kept my commits small and atomic.
I have used clear, explanatory commit messages.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.