Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove dashboard code #5883

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Deprecate and remove dashboard code #5883

merged 1 commit into from
Nov 4, 2024

Conversation

nvandoorn
Copy link
Contributor

@nvandoorn nvandoorn commented Oct 23, 2024 •
edited
Loading

As stated by jarednorman (in #4860):

None of this provides any real value. Adding a custom dashboard is
trivial and I really don't think we need a custom permission set and
empty controller/view.

This is a rework of #5448 and fixes #4860.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@nvandoorn nvandoorn requested a review from a team as a code owner October 23, 2024 21:36
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Oct 23, 2024
MadelineCollier
MadelineCollier approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@MadelineCollier MadelineCollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nvandoorn nvandoorn force-pushed the 4860-deprecate-and-remove-dashboards-code branch 4 times, most recently from c7ce93e to 8922818 Compare October 31, 2024 18:28
@nvandoorn
Copy link
Contributor Author

Pushed a new revision to remove a spec we don't need anymore.

@tvdeyen
Copy link
Member

tvdeyen commented Nov 1, 2024

@nvandoorn I needed to update the required checks for Rails 7.2 support that now has been merged into main. Do you mind rebasing again?

@lauriejefferson @nvandoorn
Deprecate and remove dashboard code
80dcf59 
As stated by jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.
@nvandoorn nvandoorn force-pushed the 4860-deprecate-and-remove-dashboards-code branch from 8922818 to 80dcf59 Compare November 1, 2024 17:05
@nvandoorn
Copy link
Contributor Author

@tvdeyen Of course! Just pushed another revision.

@tvdeyen tvdeyen added this to the 4.4 milestone Nov 1, 2024
@tvdeyen tvdeyen merged commit d955ca4 into solidusio:main Nov 4, 2024
14 checks passed
@tvdeyen
Copy link
Member

tvdeyen commented Nov 4, 2024

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@jarednorman jarednorman Awaiting requested review from jarednorman

@MadelineCollier MadelineCollier Awaiting requested review from MadelineCollier

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Deprecate and remove "dashboards" code
5 participants
@nvandoorn @tvdeyen @jarednorman @MadelineCollier @lauriejefferson