Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see Node 16 is now past EOL, which means the stacking vulns on the docker images is increasing with no known way to resolve.
I pulled this package down and ran the test suite against Node 18 and it passed. Ran it against Node 20 and it failed.
I imagine thats a bit more difficult to patch. So I thought I would go through the images and upgrade to 18. I debated keeping 16 in the matrix to do both, but since its EOL and no more patches - it seemed like a waste of space.
I'm sure this isn't the proper way to do this upgrade, especially since I changed
lts
to18
, but since LTS is now 20. It seems safer to call out the specific node version in play.Maybe this becomes a 2.0 branch?
fixes: #1028