Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sohonet fixes #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/puppet/type/volume_group.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@
desc "The list of physical volumes to be included in the volume group; this
will automatically set these as dependencies, but they must be defined elsewhere
using the physical_volume resource type."
munge do |value|
if value.is_a?(Hash) then
value.keys.sort
else
value
end
end

def insync?(is)
if @resource.parameter(:followsymlinks).value == :true
Expand Down
11 changes: 11 additions & 0 deletions manifests/logical_volume.pp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
Boolean $mountpath_require = false,
Boolean $mounted = true,
Boolean $createfs = true,
$mountpath_fs_permissions = undef,
$extents = undef,
$stripes = undef,
$stripesize = undef,
Expand Down Expand Up @@ -120,5 +121,15 @@
dump => $fixed_dump,
atboot => true,
}

if $mountpath_fs_permissions {
exec { "ensure permissions for '${fixed_mountpath}' are correct":
path => [ '/bin', '/usr/bin' ],
require => Mount[$mount_title],
subscribe => Mount[$mount_title],
refreshonly => true,
command => "chown ${mountpath_fs_permissions}:${mountpath_fs_permissions} ${fixed_mountpath}",
}
}
}
}