Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/308 init with remotes #323

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature/308 init with remotes #323

wants to merge 4 commits into from
+207 −117

Conversation

nheeb
Copy link
Contributor

@nheeb nheeb commented Feb 28, 2025

The new #308 problems should be fixed.

@poikilotherm poikilotherm requested a review from SKernchen March 11, 2025 09:56
SKernchen
SKernchen previously approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@SKernchen SKernchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

One problem i got is that the authentification with github used the wrong remote url/project.
So my test remote did not have any rights and the other remote got the secrets and permissons.

@SKernchen SKernchen self-requested a review March 17, 2025 12:41
@SKernchen SKernchen dismissed their stale review March 17, 2025 12:41

Found a bug

@SKernchen SKernchen assigned nheeb and unassigned SKernchen Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKernchen SKernchen

At least 1 approving review is required to merge this pull request.

Assignees

@nheeb nheeb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nheeb @SKernchen