[iOS] Add FabricComponents to Podfile #3388
Conversation
| @@ -29,4 +29,13 @@ Pod::Spec.new do |s| | |||
| else | |||
| s.dependency "React-Core" | |||
| end | |||
|
|
|||
| if ENV['USE_FRAMEWORKS'] != nil && ENV['RCT_NEW_ARCH_ENABLED'] == '1' | |||
There was a problem hiding this comment.
I believe it'd be better to check if ENV['USE_FRAMEWORKS'] == 'static' rather than != nil, as USE_FRAMEWORKS could be set to dynamic.
There was a problem hiding this comment.
I've done it the same way as Live Markdown does, maybe @tomekzaw will have more insights on that
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
RNGestureHandler.podspec
Outdated
| "react/renderer/textlayoutmanager/platform/ios", | ||
| "react/renderer/components/textinput/platform/ios", | ||
| ]) | ||
| add_dependency(s, "React-rendererconsistency") |
There was a problem hiding this comment.
As far as I see, we don't need to include the React-rendererconsistency dependency.
Both of the lacking components are provided by React-FabricComponents, which is already included 3 lines higher.
Tested on new arch RN 0.77 on a successful repro, and including React-FabricComponents was enough to fix the occurring issues.
There was a problem hiding this comment.
You're right, removed in aa8e331
|
Is this already available in 2.23? or shoudl we meanwhile still use 2.22? |
|
Seems the something failed because the v2.23.1 was not published @m-bert |
|
2.23.1 was indeed not published on npm yet. |
|
Yes, I'm aware that it was not published yet, there were some complications and I hope that it will be released today |
|
FYI, I've just released 2.23.1 with this fix. |
Description
This PR updates
RNGestureHandler.podspecto fix builds on iOS, which broke after #3338.Fixes #3385
Test plan
Verified by users (see issue)
Tested on fresh React Native 0.77 app with the following line in
Podfile: