Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Text with RN component when callbacks are not specified #3336

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Replace Text with RN component when callbacks are not specified #3336

merged 2 commits into from
Jan 20, 2025

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jan 15, 2025

Description

This PR replaces our Text component with default RN component, when onPress or onLongPress callbacks are not provided.

Should help with #3331

Test plan

Tested on code from NestedText example with variations:

Additional View/Text inside Touchable, with/without onPress on outer Text.

@m-bert m-bert changed the title Replace Text with RN component when callbacks are not specified. Replace Text with RN component when callbacks are not specified Jan 15, 2025
@m-bert m-bert mentioned this pull request Jan 15, 2025
Open
@m-bert m-bert requested a review from j-piasecki January 15, 2025 12:17
@m-bert m-bert merged commit 5f3211d into main Jan 20, 2025
1 check passed
@m-bert m-bert deleted the @mbert/replace-text branch January 20, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bert @j-piasecki