Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salad card bug #87

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Fix salad card bug #87

merged 5 commits into from
Jan 20, 2025

Conversation

YoEnte
Copy link
Contributor

@YoEnte YoEnte commented Jan 19, 2025

Description

I fixed a bug, where salad card moves where listed in possible moves even though the player has no salads left
Actually it is a bug for card.play() anywhere it is used, but got noticed at possible_moves()
(+ Added a logic file to gitignore which I use for testing)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested it multiple times in game, wheter the possible move is listed or not
Created a new rust test in card_test.rs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@maxblan
Copy link
Collaborator

maxblan commented Jan 20, 2025

Great! Thank you very much for your help and patience. :)

@maxblan maxblan merged commit 3edfc91 into master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants