Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lighter terminal.ansiBrightBlack #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francoiscote
Copy link
Contributor

I know terminal.ansiBrightBlack (fg=8) is the default color for auto-suggestions under zsh.

In that case, it would make sense to have it set for a very low contrast. See screenshot, I typed git clone and the git url is auto-suggested.

screen shot 2019-01-30 at 11 16 49 pm

@lovemecomputer
Copy link
Member

lovemecomputer commented Feb 4, 2019

@francoiscote omg good catch, this makes a lot of sense!! i use fish and also get that dark prediction text, and i agree with your change!! lemme test out this hex vs a couple others before merging

edit: document that i am testing change:

from:

"terminal.ansiBrightBlack": "#6f5573",

to:

"terminal.ansiBrightBlack": "#e7cecd",

@lovemecomputer lovemecomputer added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2019
@lovemecomputer
Copy link
Member

adding a note: i want to also find what rule is necessary to define for autocomplete in fish shell, as unfortunately this change doesn't affect fish

@francoiscote
Copy link
Contributor Author

I actually switched to fish not long after opening this PR, and I think it also uses Bright Black.

@lovemecomputer
Copy link
Member

hey sorry for delays on this pr!! my local dev link for the theme got broken somehow, and i was distracted from fixing it with work milestones 😇

i'll take a look at this more bc for some reason i'm not seeing the change from this PR on my end. maybe i just need to update some things…

@francoiscote
Copy link
Contributor Author

hey! I used to have this as an override in my settings. Today I properly set up VSCode and vsce to use this repo as my theme, and used this branch as a test. I get the correct color for ansiBrightBlack. Let me know if I can help you investigate further.

@francoiscote francoiscote force-pushed the terminal-ansiiBrightBlack branch from c85c218 to 34399d4 Compare February 6, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants