Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softer brackets match colors #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francoiscote
Copy link
Contributor

@francoiscote francoiscote commented Jan 31, 2019

hi there!

here is a suggestion for softer colors on bracket matches. You see those only if you have "editor.matchBrackets": true in your settings.

@francoiscote
Copy link
Contributor Author

oh, I just saw in your screenshot that you do have bracket matching enabled, and that you decided to highlight them with this dark background. Feel free to disregard this PR if you don't like it. 👍

@lovemecomputer
Copy link
Member

lovemecomputer commented Feb 4, 2019

aaaa thanks for the thoughts @francoiscote ! i rly like this hex u chose, but i'm concerned that a feature like bracket matching needs more extreme contrast to make it highly noticeable… but i also do think it's a bit hard on the contrast at the moment. i will think about this PR a bit before deciding what to do!

@lovemecomputer lovemecomputer added the enhancement New feature or request label Feb 4, 2019
@francoiscote francoiscote force-pushed the softer-brackets-highlights branch from bfb2488 to f69e828 Compare February 6, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants