Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.2 zhile #454

Open
wants to merge 18 commits into
base: 3.x
Choose a base branch
from
Open

3.1.2 zhile #454

wants to merge 18 commits into from

Conversation

kailll
Copy link
Contributor

@kailll kailll commented Oct 8, 2021

Motivation:

bug fix

Modification:

修复采样率传递问题
stat 时间段整分钟
dataSource 部分enpoint为空
dataSource pg读写url解析
dataSource resultCode一直是N的bug

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

glmapper and others added 14 commits February 24, 2021 09:39
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md)
- [Commits](junit-team/junit4@r4.12...r4.13.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khotyn Huang <[email protected]>
Optimize imports of SOFATracer, such a lot of unused import.
close sofastack#428
* Add functional support and test cases
* support logging.file.path
* Speed up test case by removing sleep code
stat 时间段整分钟
dataSource 部分enpoint为空
dataSource pg读写url解析
dataSource resultCode一直是N的bug
@sofastack-bot
Copy link

sofastack-bot bot commented Oct 8, 2021

Hi @kailll, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

if("true".equals(SofaTracerConfiguration.getProperty(SofaTracerConfiguration.FILL_MINUTE_SWITCH))){
initialDelay = DateUtils.diffNextMinute(new Date());
}
executor.scheduleAtFixedRate(new StatReporterPrinter(), initialDelay, cycleTime, TimeUnit.SECONDS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处initialDelay的单位是mills, 而scheduleAtFixedRate要求initialDelay和interval的单位由第4个参数指定.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@sofastack-bot sofastack-bot bot added cla:yes and removed cla:no labels Oct 18, 2021
@sofastack-bot sofastack-bot bot added size/XXL and removed size/XL labels Oct 18, 2021
@glmapper
Copy link
Contributor

@kailll pls rebase your brach,there are to much irrelevant commit record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants