[WIP] Support customer exception #1411
Conversation
WalkthroughThe updates introduce handling and configuration for user-defined exceptions within the SOFARPC framework. This allows for custom exceptions to be specified for retry logic, enhancing flexibility for business applications to manage retries based on specific needs. Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (5)
Additional comments not posted (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| /** | ||
| * 用户自定义异常集合 | ||
| */ | ||
| protected List<String> customerExceptions = getListValue(CONSUMER_EXCEPTIONS); |
There was a problem hiding this comment.
Consider renaming customerExceptions to consumerExceptions to maintain naming consistency with the static import CONSUMER_EXCEPTIONS.
- protected List<String> customerExceptions = getListValue(CONSUMER_EXCEPTIONS);
+ protected List<String> consumerExceptions = getListValue(CONSUMER_EXCEPTIONS);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| protected List<String> customerExceptions = getListValue(CONSUMER_EXCEPTIONS); | |
| protected List<String> consumerExceptions = getListValue(CONSUMER_EXCEPTIONS); |
| public List<String> getCustomerExceptions() { | ||
| return customerExceptions; | ||
| } | ||
|
|
||
| public void setCustomerExceptions(List<String> customerExceptions) { | ||
| this.customerExceptions = customerExceptions; | ||
| } |
There was a problem hiding this comment.
The getter and setter methods for customerExceptions are correctly implemented. However, consider renaming them to align with the suggested field name change to consumerExceptions.
- public List<String> getCustomerExceptions() {
+ public List<String> getConsumerExceptions() {
return consumerExceptions;
}
- public void setCustomerExceptions(List<String> customerExceptions) {
+ public void setConsumerExceptions(List<String> consumerExceptions) {
this.consumerExceptions = consumerExceptions;
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| public List<String> getCustomerExceptions() { | |
| return customerExceptions; | |
| } | |
| public void setCustomerExceptions(List<String> customerExceptions) { | |
| this.customerExceptions = customerExceptions; | |
| } | |
| public List<String> getConsumerExceptions() { | |
| return consumerExceptions; | |
| } | |
| public void setConsumerExceptions(List<String> consumerExceptions) { | |
| this.consumerExceptions = consumerExceptions; | |
| } |
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit